Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable travis-ci for docker-node repo #378

Closed
chorrell opened this issue Apr 4, 2016 · 2 comments
Closed

Enable travis-ci for docker-node repo #378

chorrell opened this issue Apr 4, 2016 · 2 comments

Comments

@chorrell
Copy link

chorrell commented Apr 4, 2016

Hi there,

I hope this is the right place for this :)

I want to enable a simple Docker image build test for https://github.com/nodejs/docker-node using Travis-CI. It will help streamline our workflow when updating the image as the test builds will happen automatically. I did a test over here on a fork to make sure it actually worked;

Here's the relevant PR to add the appropriate .travis.yml file to the repo:

nodejs/docker-node#139

@jbergstroem
Copy link
Member

I think this could just as well belong with the docker-node repo seeing how it doesn't really involve ci or our infrastructure. My only remark to such a PR would be making a distinction wrt testing that building works versus running the test suite within that docker container. A badge wouldn't necessarily explain this.

@chorrell
Copy link
Author

chorrell commented Apr 5, 2016

So apparently I was a bit confused about how to go about setting this up -- I assumed the the build group had some kind of access that I didn't but it turns out third-party app integrations were disabled for the org:

nodejs/nodejs.org#355 (comment)

I think I've managed to figure out what I need to do to get this working:

https://travis-ci.org/nodejs/docker-node/builds/120784170

RE: the badge

Yeah, good point. It's not really necessary so I'll just not bother adding it since it may cause some confusion.

@chorrell chorrell closed this as completed Apr 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants