Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: add some validation to ci-release iojs+release #1592

Closed
refack opened this issue Nov 23, 2018 · 1 comment
Closed

FR: add some validation to ci-release iojs+release #1592

refack opened this issue Nov 23, 2018 · 1 comment

Comments

@refack
Copy link
Contributor

refack commented Nov 23, 2018

The current job takes several free-form strings parameters that end up in the build output. Downstream tools assume a consistent format for these value, but the job does not validate those assumptions on the input.

As a result we can create https://nodejs.org/download/nightly/v11.0.0-nightly201806050300f7c68cffa5de7f0099e3afa95093b0bbbe3c/
Or
https://nodejs.org/download/nightly/v12.0.0-nightly20181122.2.94a2c9c8e5/
which will probably bork downstream tools.

tl;dr and some validate code to the job.

Refs: nodejs/node#24551 (comment)

@github-actions
Copy link

github-actions bot commented Mar 6, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is remove or a comment is made.

@github-actions github-actions bot added the stale label Mar 6, 2020
@github-actions github-actions bot closed this as completed Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant