Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new github-bot personal token for nodejs/node-v8 automation #587

Closed
targos opened this issue Feb 28, 2021 · 15 comments
Closed

Create new github-bot personal token for nodejs/node-v8 automation #587

targos opened this issue Feb 28, 2021 · 15 comments

Comments

@targos
Copy link
Member

targos commented Feb 28, 2021

A token is needed with the public_repo and workflow scopes.
This is for a daily workflow that will update the node-v8's canary branch with latest Node.js commit and V8 lkgr. workflow is needed for cases where the Node.js update contains changes to .github/workflows.

Reference: nodejs/node-v8#171

/cc @nodejs/tsc @nodejs/community-committee

@Trott
Copy link
Member

Trott commented Feb 28, 2021

+1

2 similar comments
@joyeecheung
Copy link
Member

+1

@mhdawson
Copy link
Member

mhdawson commented Mar 1, 2021

+1

@targos
Copy link
Member Author

targos commented Mar 7, 2021

@nodejs/community-committee PTAL

@targos
Copy link
Member Author

targos commented Mar 13, 2021

Ping

@mmarchini
Copy link
Contributor

Added to commcomm agenda as it needs one more approval from them

@bnb
Copy link
Contributor

bnb commented Mar 18, 2021

Hi hello yes, +1

@joesepi
Copy link
Member

joesepi commented Mar 18, 2021

Hi. +1 from me too.

@targos
Copy link
Member Author

targos commented Mar 19, 2021

Thank you!

@mmarchini I think you're one of the few people who both have access to the github bot and repository settings? Would you be able to create the token and add it to https://github.com/nodejs/node-v8/settings/secrets/actions/new ?

@targos
Copy link
Member Author

targos commented Mar 31, 2021

I don't know who else to ask 😕

@bnb
Copy link
Contributor

bnb commented Apr 1, 2021

@targos AFAIK this is approved. I'm also waiting on a token for a different issue, this seems to be highlighting a bottleneck. Perhaps @mhdawson could help advise us?

@mhdawson
Copy link
Member

mhdawson commented Apr 8, 2021

@bnb I've not been in the loop of creating tokens in the past. I think @joyeecheung was involved in the github bot work. @joyeecheung do you know?

@joyeecheung
Copy link
Member

I've added a CANARY_UPDATE token with the scopes mentioned in the OP, @targos can you try it out?

@joyeecheung
Copy link
Member

BTW all I did was creating a personal access token and adding it to the repository, according to the documentation here https://docs.github.com/en/actions/reference/authentication-in-a-workflow

@targos
Copy link
Member Author

targos commented Apr 11, 2021

Thank you @joyeecheung, it's working !

@targos targos closed this as completed Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants