Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move node-ment repo into the Node.js Org #35

Closed
bnb opened this issue Dec 28, 2017 · 24 comments
Closed

Move node-ment repo into the Node.js Org #35

bnb opened this issue Dec 28, 2017 · 24 comments

Comments

@bnb
Copy link
Contributor

bnb commented Dec 28, 2017

@Bamieh has done a TON of work on a repo around Mentorship as a part of the discussion around mentorship in the CommComm (ref: nodejs/community-committee#172).

As per our last CommComm meeting (ref: nodejs/community-committee#199) we've agreed to begin the process of pulling the repo that @Bamieh has worked on into the Node.js Org - and begin co-ordinating work around it as necessary.

Here's the repo: Bamieh/node-ment

cc @nodejs/community-committee @nodejs/tsc

@mcollina
Copy link
Member

SGTM

@Trott
Copy link
Member

Trott commented Dec 28, 2017

No objections either way, but if possible, it would be great if it could be named more descriptively. nodejs/mentor-program or something like that?

@Bamieh
Copy link
Contributor

Bamieh commented Dec 28, 2017

@Trott how about mentorship? Should I transfer it now?

@joyeecheung
Copy link
Member

nodejs/mentorship SGTM. (I had no idea what node-ment was from the first glance..)

@Bamieh
Copy link
Contributor

Bamieh commented Dec 28, 2017

I thought it was a cool name (node-ment) lol. Anyways I renamed the repo to mentorship. I attempted to do a transfer but i got this message:

image

So i guess someone has to create a repo from nodejs side so i can transfer it or something..

@Trott
Copy link
Member

Trott commented Dec 28, 2017

So i guess someone has to create a repo from nodejs side so i can transfer it or something..

I imagine there's no rush on this. This issue has been open for 12 hours. It would be good to give people more time than that to express opinions, especially at a time when a lot of people are away from their computers. I don't expect any objections to this but ¯\(ツ)/¯.

Assuming nothing too exciting happens in this issue, if no one's created the repo by end of UTC day January 2, post here or send me an email and I'll create it.

(And if someone feels differently and creates the repo 5 minutes after I've posted this, I'm OK with that too. I just don't want to be the person who does that myself.)

@mhdawson
Copy link
Member

mhdawson commented Jan 2, 2018

SGTM

@Bamieh
Copy link
Contributor

Bamieh commented Jan 3, 2018

@Trott it's january 3rd already 😄

@Trott
Copy link
Member

Trott commented Jan 3, 2018

Hi, @Bamieh! Would you be willing to give me admin privileges on https://github.com/Bamieh/mentorship so I can transfer it into the nodejs org?

@Bamieh
Copy link
Contributor

Bamieh commented Jan 4, 2018

invitation sent

@Trott
Copy link
Member

Trott commented Jan 4, 2018

invitation sent

Cool. I'm a member now. I think you need to change my role to Owner for me to be able to transfer it to the nodejs org.

@Bamieh
Copy link
Contributor

Bamieh commented Jan 5, 2018

@Trott this is what i thought i'd have to do. But this is what i got instead:

image

After reading about it on github:

There is only one owner of a repository owned by a user account; this permission cannot be shared with another user account. To transfer ownership of a repository to another user, see "How to transfer a repository."

so i do not believe this is possible. Maybe we have to do something else?

  • Transfer ownership to you then you transfer ownership
  • Create a repo on nodejs and i will submit the initial commit to the repo
  • Create the mentorship repo and give me admin access on it so i can transfer ownership to it

@bnb I believe this should be addressed in the STRATEGIC-INITIATIVES?

@ljharb
Copy link
Member

ljharb commented Jan 5, 2018

@Trott @Bamieh the only way to do this is to do one of the following:

  1. temporarily grant @Bamieh the ability to create repos in the nodejs org, by making them an owner.
  2. @Bamieh, you would transfer your repo to another person who is an owner in the nodejs org, like @Trott - who would then bounce it into the nodejs org. Repo redirects will work forever (until @Trott, aka the bouncer, creates a repo with the same name, or forks the repo).
  3. Create a new "nodejs-transfer" org. Make all nodejs org owners, owners in that org. Allow all nodejs-transfer org members to transfer repos into it. Make @Bamieh a nodejs-transfer org member. @Bamieh moves the repo into the transfer org, and then a nodejs org owner bounces it into the nodejs org.

Sadly github doesn't have any better choices than this.

@Bamieh
Copy link
Contributor

Bamieh commented Jan 5, 2018

@ljharb # 3 seems the most scalable (for future initiative transfers as well) and protects from the issue addressed in # 2. Maybe we do not have to have ALL nodejs owners in that org, rather than just a few owners assigned the responsibility for transfers.

Although i am not completely against # 1 as a temp solution, but i highly discourage doing this hack (for me or for others in the future) as it's risky for both parties.

I also thought this option is also possible, any ideas?

Create the mentorship repo and give me admin access on it so i can transfer ownership to it

@ljharb
Copy link
Member

ljharb commented Jan 5, 2018

No, that's not possible, since personal repos can only ever have that one admin.

You're right that the third option is the most scalable; the first option is likely untenable due to the risk in giving out that much access to the nodejs org; the second option is the most convenient but requires more coordination.

@bnb
Copy link
Contributor Author

bnb commented Jan 5, 2018

I am happy to help execute on any of this - please let me know how I can help!

@Trott
Copy link
Member

Trott commented Jan 6, 2018

I'm not sure who we'd have to involve create a new org like nodejs-transfer or whatever. Worst case, I put this on the agenda for the TSC meeting and hopefully can figure stuff out there. But a solution sooner would be nice.

@Fishrock123
Copy link
Contributor

If owner permissions are required, I already have a "testing" org set up that could be used to do a transfer were we don't need to give owner rights to the nodejs org.

I/We can give folks owner rights to https://github.com/TestOrgPleaseIgnore and then it can be moved there first, and then myself or someone else could move it here.

GitHub will handle redirects for this correctly, AFAIK.

@targos
Copy link
Member

targos commented Jan 10, 2018

Any member of the org has the right to create repositories, not only owners. We should just add @Bamieh to a team.

@Bamieh
Copy link
Contributor

Bamieh commented Jan 10, 2018

The mentorship program is now under nodejs 🎉 https://github.com/nodejs/mentorship

Feel free to close this issue

Cheers!

@Trott
Copy link
Member

Trott commented Jan 10, 2018

Thanks, whoever made it happen! :-D

@Trott Trott closed this as completed Jan 10, 2018
@Trott Trott removed the tsc-agenda label Jan 10, 2018
@Bamieh
Copy link
Contributor

Bamieh commented Jan 10, 2018

haha thanks @Trott for making it happen!

@Trott
Copy link
Member

Trott commented Jan 10, 2018

haha thanks @Trott for making it happen!

Wasn't me! I just brought it to the TSC meeting and kinda threw up my hands. I assumed it was either @Fishrock123 or @targos...

@Bamieh
Copy link
Contributor

Bamieh commented Jan 10, 2018

I transferred the repo from my account, but you were the one that invited me over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants