Potential Semver Minor Backports #188
Comments
|
I'm thinking one last one as it transitions to maintenance would make sense. |
|
#8334 would probably be appreciated by the distros that use it, and which will be maintaining 4.x for some time, though they may be cherry picking the change anyhow. The tls, src, and http will make writing portable code across LTS versions much easier. |
|
Those commits have been living in |
|
We also need to make sure we discuss the zlib update (nodejs/node#10980), see nodejs/node#10980 (comment) |
|
I went ahead and landed the zlib updates in staging. I think them not landing was an oversight. If anyone can think of any reasons to pull it we can do so and discuss |
|
edit: sorry for saying that in such a final way... didn't see above where you were posing that as a question to the group. I was under the impression after the last minor that we were not going to do any more for v4.x This can obviously be discussed if people see a reason to do so edit 2: I kinda just chimed in here without reading the comments from all of you in here regarding another minor for v4.x, not feeling great about the way I responded. To explain my point. We usually do a month long RC process for a minor, generally two weeks after the previous release, to allow for enough commits to collect. We just did a minor last month. Doing the proper cycle would bring us to May before we could release. We've had people bring up to us in the past that they want us to maintain our contract for releasing, I think the right thing to do is to properly move to maintenance, rather than doing a minor that is in my opinion a bit rushed. |
|
If someone adds me to the repo I can edit - in the meantime, @gibfahn , can you add to 8334 a ref to it's 6.x backport: nodejs/node#11794 |
|
I'm not sure how patches to a maintenance v4.x get discussed, but it makes sense (at least to me) to raise them for discussion in the same way we currently discuss semver-minor backports to Active LTS. For example, I was looking through some old testcase failures, and I noticed that nodejs/node#10212 wasn't backported to v4.x. This is something we've seen fail quite a few times in v4.x, so it might be worth considering it for backporting. |
|
@gibfahn do you want to update this list before the meeting tomorrow? |
|
nodejs/node#11220 should not be backported to any LTS branch. |
|
Nor should nodejs/node#10739 |
|
I missed end of meeting, but: #10209 might need baking, but should backport for consistency |
|
@sam-github that was discussed and the conclusion in the meeting |
|
@MylesBorins I think everything here is done and this can be closed now (reopen if you disagree...) |
Some more semver-minors to consider, now that #177 is closed.
Semver-minor v6.x backports:
I ran
branch-diff --reverse --filter-release --require-label=semver-minor --exclude-label=semver-major,meta,dont-land-on-v6.x,backport-requested-to-v6.x up/v6.x up/v7.xNot sure why it didn't include this (from the search query), maybe because the backport PR has
do-not-landand didn't havesemver-major, and thePR-URLwas changed:Backports
Yes
570c5e1da8] - (SEMVER-MINOR) crypto: support OPENSSL_CONF again (Sam Roberts) #110068be6702539] - (SEMVER-MINOR) src: add SafeGetenv() to internal API ( Sam Roberts) #1100608a7e7b009] - (SEMVER-MINOR) crypto: returnthisin setAuthTag/setAAD ( Kirill Fomichev) #9398ac2b059500] - (SEMVER-MINOR) crypto: do not use pointers to std::vector ( Adam Majer) #8334aeea13b6f6] - (SEMVER-MINOR) crypto: Use system CAs instead of using bundled ones ( Adam Majer) #8334a1897c1445] - (SEMVER-MINOR) crypto: ability to select cert store at runtime ( Adam Majer) #83340a3e5cc57a] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve6() ( Ben Noordhuis) #92961bd79368cd] - (SEMVER-MINOR) dns: implement {ttl: true} for dns.resolve4() ( Ben Noordhuis) #9296663c44eaaa] - (SEMVER-MINOR) cluster: return worker reference from disconnect() ( Sean Villars) #100192096638fe0] - (SEMVER-MINOR) tls: allow obvious key/passphrase combinations ( Sam Roberts) #10294ecb3a7e933] - (SEMVER-MINOR) test: make tls-socket-default-options tests run ( Sam Roberts) #110054e327708a9] - (SEMVER-MINOR) tls: new tls.TLSSocket() supports sec ctx options ( Sam Roberts) #11005d24491c6a7] - (SEMVER-MINOR) process: add NODE_NO_WARNINGS environment variable ( cjihrig) #1084292ed2b5001] - (SEMVER-MINOR) build: support for mips64el ( nanxiongchao) #109918ab26cf508] - (SEMVER-MINOR) readline: add option to stop duplicates in history ( Danny Nemer) #2982ffd938a694] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.2 (cjihrig) #10717786631c7b4] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.1 (cjihrig) #9647106d71914c] - (SEMVER-MINOR) deps: upgrade libuv to 1.10.0 (cjihrig) #9267Manual
Consider for backporting:
Don't need backporting:
3596d156c1] - (SEMVER-MINOR) lib: buildnode inspectintonode( Anna Henningsen) #1018785f54908bf] - (SEMVER-MINOR) deps: add node-inspect 1.10.2 (Jan Krems) #10187b1ef638de3] - (SEMVER-MINOR) src: default --icu_case_mapping on as a v8 option ( Steven R. Loomis) #94548fdfa08ed0] - (SEMVER-MINOR) build: add node-inspect integration test (Jan Krems) #1018784e2ff3738] - (SEMVER-MINOR) doc: add basic documentation for WHATWG URL API (James M Snell) #10620614742b67f] - (SEMVER-MINOR) lib: deprecate node --debug at runtime ( Josh Gavant) #11275614742b67f] - (SEMVER-MINOR) lib: deprecate node --debug at runtime (Josh Gavant) #11275c92b8ecd81] - (SEMVER-MINOR) tools: add mdn link for Iterator ( James M Snell) #1062084e2ff3738] - (SEMVER-MINOR) doc: add basic documentation for WHATWG URL API ( James M Snell) #10620a5c62cb4f2] - (SEMVER-MINOR) readline: use icu based string width calculation ( James M Snell) #9040Unsorted:
1ee38eb874] - (SEMVER-MINOR) util: add %i and %f formatting specifiers ( Roman Reiss) #1030875f4329e01] - (SEMVER-MINOR) crypto: add randomFill and randomFillSync ( Evan Lucas) #10209The text was updated successfully, but these errors were encountered: