Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agentkeepalive might leak SSL sockets #32

Closed
alexpenev-s opened this issue Mar 14, 2016 · 0 comments
Closed

Agentkeepalive might leak SSL sockets #32

alexpenev-s opened this issue Mar 14, 2016 · 0 comments

Comments

@alexpenev-s
Copy link
Contributor

Whenever ‘ca’ is set in the global object's Agent.options, but the same ‘ca’ option is not set the the requests options, a different hash_tag_name is build and existing free sockets cannot be found and used.

_http_agent.js @ Agent.prototype.createSocket
the options are extended with the global ‘properties’ object.

however _http_agent.js @ Agent.prototype.addRequest
The request options are not extended with the global ‘properties’ object. Whenever the global options object contains the property ‘ca’, but the local properties object doesn’t. A different hash_tag_name is build.

(https.getName uses the ca property when building the unique hashtag)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant