Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks with Stylelint 16.x #5

Open
yphoenix opened this issue Dec 9, 2023 · 11 comments
Open

Breaks with Stylelint 16.x #5

yphoenix opened this issue Dec 9, 2023 · 11 comments

Comments

@yphoenix
Copy link

yphoenix commented Dec 9, 2023

Everything worked upto 15.x, with 16.x everything breaks.

Should be easy to reproduce.

@yphoenix
Copy link
Author

yphoenix commented Dec 9, 2023

SyntaxError [uncaught]:
JSON Parse error: Unexpected EOF

@yphoenix
Copy link
Author

yphoenix commented Dec 9, 2023

Seems stylelint outputs to stderr instead of stdout, so easy fix.
Have fix: https://github.com/Issio-Contribute/nova-stylelint/tree/Fix-Issiue-5-Breaks-with-Stylelint-1.6.x

@jeremyfuksa
Copy link

Nudging this issue. I could sure use @yphoenix 's fix for this.

@yphoenix
Copy link
Author

Util it is merged....

Go to ~/Library/Application\ Support/Nova/Extensions/com.neelyadav.stylelint/Scripts and edit the main.dist.js file.. around line 454 change resolve(output); to resolve(output ? output : error);

@jeremyfuksa
Copy link

jeremyfuksa commented Jan 10, 2024

That does not fix it for me. Using stylelint 15.11.0 in my package.json for my project.

If I update stylelint to 16.1.0, I get an error:

> stylelint src/**/*.scss || true

[filepath]/node_modules/meow/build/index.js:29
        description &&= help ? `\n  ${description}\n` : `\n${description}`;
                    ^^^

SyntaxError: Unexpected token '&&='
    at Loader.moduleStrategy (internal/modules/esm/translators.js:149:18)

@yphoenix yphoenix changed the title Breaks with Stylelint 1.6.x Breaks with Stylelint 16.x Jan 11, 2024
@yphoenix
Copy link
Author

yphoenix commented Jan 11, 2024

What version of node are you using? &&= came in with node v15 and stylelint 16.x needs 18.12.0 or newer

@jeremyfuksa
Copy link

Upgraded to 18.17.1 and made the code edit. I'm still getting the crash.

@yphoenix
Copy link
Author

Maybe there is something amiss about the node_modules associated with your stylelint install. It's the extension that is using the meow node module. The version I have installed in com.neelyadav.stylelint/Batteries/node_modules/meow/package.json is v9.0.0

So I did:

cd ~/Library/Application Support/Nova/Extensions/com.neelyadav.stylelint/Batteries
npm update

To update the associated modules

@yphoenix
Copy link
Author

I wonder what version of meow you have installed as the code you are showing for the error doesn't match the code in meow/index.js

@jeremyfuksa
Copy link

jeremyfuksa commented Jan 12, 2024

meow isn't listed in the package.json in Batteries. I did an npm-check-updates run on the package.json in Batteries and my project.

meow in my project is 13.1.0.

After bumping dependencies in Batteries, the initial crash is gone, but now I get a new error in the Extension Console:

Stylelint[10:35:41.357000] TypeError [uncaught]:
Right side of assignment cannot be destructured@file:///Users/jf065530/Library/Application%20Support/Nova/Extensions/com.neelyadav.stylelint/Scripts/main.dist.js:315:50

@JDENredden
Copy link

Thanks @yphoenix !

Has the dev abandoned this project? Maybe your fork should take over?

Repository owner deleted a comment from nerypy Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants