Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soft-deprecate shadow_shift #193

Closed
njtierney opened this issue Aug 12, 2018 · 1 comment · Fixed by #324
Closed

soft-deprecate shadow_shift #193

njtierney opened this issue Aug 12, 2018 · 1 comment · Fixed by #324
Labels
maintenance Priority 1
Milestone
V1.1.0

Comments

@njtierney
Copy link
Owner

In relation to #159 - as shadow_shift is effectively the same as impute_below, but impute below more clearly states what it does. This is especially try when we think of the new shade and shadow classes in #189.
@njtierney njtierney added this to the V0.5.0 milestone Aug 12, 2018
@njtierney
Copy link
Owner Author

In accordance with this, I will need to make sure that I remove shadow_shift from geom_miss_point and co. But this should show up in the tests

@njtierney njtierney mentioned this issue Aug 12, 2018
Merged
@njtierney njtierney modified the milestones: V0.5.0, V0.6.0 May 19, 2020
@njtierney njtierney modified the milestones: V0.6.0, V0.7.0, V0.8.0 Oct 14, 2022
@njtierney njtierney mentioned this issue Apr 11, 2023
Closed
@njtierney njtierney modified the milestones: V0.8.0, V0.7.0 Apr 11, 2023
@njtierney njtierney mentioned this issue Apr 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Priority 1
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging a pull request may close this issue.

Update imputers and provide documentation for impute functions njtierney/naniar
1 participant
@njtierney