-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Date method for impute_below #158
Labels
Milestone
Comments
One thing to keep in mind here is:
|
It seems reasonable to convert the date to numeric and then coerce back to a date |
njtierney
changed the title
shadow-shift / impute-below doesn't handle dates
Add Date method for impute_below
Apr 24, 2023
njtierney
added a commit
that referenced
this issue
May 1, 2023
- Convert to numeric, then impute and convert back to relevant class - add tests for geom_miss_point() and other dates - Resolves #158
There are three extra methods now:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
shadow_shift and therefore
impute_below
don't handle date objects:Created on 2018-05-03 by the reprex package (v0.2.0).
This should be able to be fixed by doing some conversion to a numeric object, then sending it back as a whole integer.
The text was updated successfully, but these errors were encountered: