Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate definition of clockid #1314

Open
maxbla opened this issue Oct 13, 2020 · 1 comment
Open

Duplicate definition of clockid #1314

maxbla opened this issue Oct 13, 2020 · 1 comment
Assignees
@SteveLauC

Comments

@maxbla
Copy link
Contributor

maxbla commented Oct 13, 2020 •
edited
Loading

Is there some reason that we have both nix::time::ClockId and nix::sys::timerfd::ClockId? It seems like nix::time::ClockId is more complete - defining more types of clocks for different operating systems. It looks to me like the timerfd implementation could be entirely replaced by the time one.

I would be happy to submit a PR removing nix::sys::timerfd::ClockId (if doing so makes sense). Obviously this would be a breaking change, so it may have to wait.
@maxbla
Copy link
Contributor Author

maxbla commented Oct 21, 2020

It looks like nix::time::ClockId was added fairly recently in #1281. I suggest removing nix::sys::timerfd::ClockId when we're next allowed a breaking change.

@SteveLauC SteveLauC self-assigned this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteveLauC SteveLauC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxbla @SteveLauC