Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DELETE macro conflict #32

Open
robozman opened this issue Aug 13, 2019 · 1 comment
Open

DELETE macro conflict #32

robozman opened this issue Aug 13, 2019 · 1 comment

Comments

@robozman
Copy link

I'm having an issue when compiling a program that uses qhttpengine on Windows.
The use of DELETE at

is resolving the DELETE macro that in defined in winnt.h. This is causing the compile to fail with a syntax error.

My current workaround for this is to rename the DELETE in socket.h to something else but this obviously isn't a good solution to the problem.

Thanks for your help and for your software!

@nathan-osman
Copy link
Member

One possible option (assuming you don't need the DELETE constant from winnt.h) is to add the following line before including socket.h:

#undef DELETE
#include <qhttpengine/socket.h>

As for a long term solution, let me give this some careful thought.

(This is one of the reasons I don't like #defines - it pollutes the global namespace and causes problems like this.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants