Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS backend #59

Open
konsumlamm opened this issue Jan 1, 2022 · 1 comment
Open

JS backend #59

konsumlamm opened this issue Jan 1, 2022 · 1 comment

Comments

@konsumlamm
Copy link
Contributor

I experimented a bit with running the tests on the JS backend, but I came to the conclusion that this is currently not viable. The problem is nim-lang/Nim#4714: 64 bit integers are broken on the JS backend, since they're implemented as floating point values.

We could use std/jsbigints on the JS backend, but I'd rather not do that, since it has a different API, which means we'd have to implement some functions twice. Apart from that, this library wouldn't be a pure Nim implementation anymore then.
@konsumlamm konsumlamm mentioned this issue Jan 21, 2022
Closed
@konsumlamm
Copy link
Contributor Author

A possible (temporary) fix for this would be to use uint16/uint32 instead of uint32/uint64 on the JS backend. That should only require changing a few types and constants, which should be doable by placing some type aliases and consts in a when at the top.

@konsumlamm konsumlamm mentioned this issue Jan 26, 2022
Closed
@konsumlamm konsumlamm mentioned this issue Dec 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@konsumlamm