Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this middleware beneficial? #5

Closed
ghost opened this issue Feb 22, 2016 · 2 comments
Closed

Is this middleware beneficial? #5

ghost opened this issue Feb 22, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 22, 2016

I'm curious, what are the benefits of using this middleware when Raven is designed to capture exceptions at the window scope out of the box (assuming the following known issue is fixed): getsentry/sentry-javascript#424

@ngokevin
Copy link
Owner

It also passes the Redux store to Sentry. Some issues with Sentry not being able to handle large messages though.

@ghost
Copy link
Author

ghost commented Feb 22, 2016

What you mentioned. Passing Redux store to Sentry. I could see that being useful in the recreation of errors assuming state can be properly reconstructed from the object passed. The risk involved is that it's more likely sensitive data, which could be temporarily stored in app state, such as Personally Identifiable Information or passwords, could also be passed inadvertently if that info is not redacted somehow prior to transmission.

@ghost ghost closed this as completed Feb 22, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant