vscode extension not terminating on vscode shutdown / restart, memory overload?

[fishcakess]

Hello,

We've recently installed the plugin and noticed our VM was running at near max capacity. This could be us not terminating vscode correctly but just FYI, we killed these processes manually. We have two seperate vscode instances connected but have a few tabs open. Seems reconnecting the next day doesn't kill it?

blank:~/wgs_aws_batch$ ps aux | grep java
user  494726  0.0  0.1 3110024 2624 ?        Sl   Nov18  11:25 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  495869  0.0  0.0 3108996 1244 ?        Sl   Nov18  11:19 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  502854  0.0  0.0 3108996 1516 ?        Sl   Nov18  11:34 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  506364  0.0  0.1 3108996 2620 ?        Sl   Nov18  11:10 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  537424  0.0  0.1 3105912 3612 ?        Sl   Nov19   9:50 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  542139  0.0  0.2 3108996 5488 ?        Sl   Nov19   9:51 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  545302  0.0  0.1 3103856 2476 ?        Sl   Nov19   9:35 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  547515  0.0  0.7 3105912 15052 ?       Sl   Nov19   9:34 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  576246  0.0  0.2 3106940 5996 ?        Sl   Nov20   8:35 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  580883  0.0  1.0 3103856 22060 ?       Sl   Nov20   8:36 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  584260  0.0  1.4 3102828 29252 ?       Sl   Nov20   8:29 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  615528  0.0  1.9 3108996 38476 ?       Sl   Nov21   7:38 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  618807  0.0  3.9 3107968 78684 ?       Sl   Nov21   7:34 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  757555  0.0  5.7 3101800 115824 ?      Sl   Nov25   3:41 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.1/bin/language-server-all.jar
user  815833  0.0  7.2 3100772 146808 ?      Sl   Nov26   2:31 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.2/bin/language-server-all.jar
user  842996  0.1  7.1 3111052 143576 ?      Sl   Nov27   1:38 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.2/bin/language-server-all.jar
user  854688  0.4  9.8 3098716 197304 ?      Sl   Nov27   4:26 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.2/bin/language-server-all.jar
user  858665  0.2  7.6 3107968 153608 ?      Sl   Nov27   2:17 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.2/bin/language-server-all.jar
user  862199  0.0  2.8 3098652 57408 ?       Sl   Nov27   0:37 g.sdkman/candidates/java/current/bin/java -jar g.vscode-server/extensions/nextflow.nextflow-1.0.2/bin/language-server-all.jar

[bentsherman]

I am seeing the same behavior in my local environment, which is VS Code on WSL. I can open a new VS Code window, start up the language server, then close the window, and in WSL I can see the language server JAR still running. So I guess the extension doesn't automatically kill any child processes when the window is closed.

I can run "Stop language server" from the command palette and I see the language server is killed.

I will try stopping the language server automatically when the extension is deactivated, in the next patch release. I'm not sure how it will work with your particular setup since VS Code can run in a lot of different environments, but we'll give it a try