Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a default revision #4427

Open
edmundmiller opened this issue Oct 18, 2023 · 1 comment · May be fixed by #5610
Open

Set a default revision #4427

edmundmiller opened this issue Oct 18, 2023 · 1 comment · May be fixed by #5610

Comments

@edmundmiller
Copy link
Contributor

New feature

In the manifest it would be nice if we could default to a git tag or commit hash.

Usage scenario

manifest {
    version         = '1.0.0'
    defaultBranch   = '1.0.0'
    // defaultRevision = '1.0.0'
}

So we don't need a master branch that is just a "stable" release, instead we can have users checkout a version by default and they won't get a dev version by mistake.

Suggest implementation

  1. Add a defaultRevision or modify the defaultBranch functionality to accept tags or commit hashs. The same functionality as -r
  2. Set the default behavior to look for a git tag, and if there isn't one default to master.
  3. If a manifest.version is set, then look for that git tag instead of using the defaultBranch on the git repo.
@bentsherman
Copy link
Member

I support deprecating defaultBranch in favor of defaultRevision which supports branch, tag, or commit hash

@edmundmiller edmundmiller linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants