Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"http" in URLs should not be captured as keys #1

Open
ashaw opened this issue May 6, 2015 · 0 comments · May be fixed by #3
Open

"http" in URLs should not be captured as keys #1

ashaw opened this issue May 6, 2015 · 0 comments · May be fixed by #3

Comments

@ashaw
Copy link

ashaw commented May 6, 2015

Currently,

noturls: value
urls:
http://foo.com
http://bar.com
:end

is parsed as

{
  "noturls": "value",
  "urls": "",
  "http": "//bar.com"
}

Desired result is:

{
  "noturls": "value",
  "urls": "http://foo.com\nhttp://bar.com"
}

I realize you can quote the URLs to escape them, but maybe the START_KEY regex should be changed to forbid "//" after a colon so file patterns are not captured as keys, since it's such a common usage. Just a thought.

@bobjflong bobjflong linked a pull request Jun 5, 2015 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant