Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout nerdpacks: Explicitly set the height on all sections so that the fullHeight prop of charts works with out extra configuration #27

Open
danielgolden opened this issue Jan 8, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers Nerdpack New Relic One application

Comments

@danielgolden
Copy link
Contributor

In some sections of the nerdpacks, when you add fullHeight to a chart, it disappears (because charts with that prop need a parent with a defined width). Not our fault, but we can help reduce the friction of having to figure that out by just defining a height on all sections by default. I think setting them all to height: 100% should do it.

@danielgolden danielgolden added enhancement New feature or request good first issue Good for newcomers Nerdpack New Relic One application labels Jan 8, 2020
@danielgolden danielgolden self-assigned this Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers Nerdpack New Relic One application
Projects
None yet
Development

No branches or pull requests

1 participant