Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the assigning of server.address to amqplib spans when using https connections #2459

Closed
bizob2828 opened this issue Aug 13, 2024 · 1 comment · Fixed by #2461
Closed

Update the assigning of server.address to amqplib spans when using https connections #2459

bizob2828 opened this issue Aug 13, 2024 · 1 comment · Fixed by #2461
Assignees
@bizob2828
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

Description

I found when trying to verify the amqplib linking with AWS MQ that the server.address was the IP not the host.

Acceptance Criteria

Use hostname when assigning server.address to amqplib spans.
@bizob2828 bizob2828 added the points: 5 1-2 weeks label Aug 13, 2024
@bizob2828 bizob2828 self-assigned this Aug 13, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-302590

@newrelic-node-agent-team newrelic-node-agent-team moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Aug 13, 2024
@bizob2828 bizob2828 mentioned this issue Aug 13, 2024
Merged
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done: Issues recently completed in Node.js Engineering Board Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizob2828 bizob2828

Labels
points: 5 1-2 weeks
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
1 participant
@bizob2828