@aws-sdk/[email protected] fails to add aws.* attributes to the external span #2378
Comments
newrelic-node-agent-team
moved this to Triage Needed: Unprioritized Features
in Node.js Engineering Board
bizob2828
moved this from Triage Needed: Unprioritized Features
to In progress: Issues being worked on
in Node.js Engineering Board
bizob2828
changed the title
@aws-sdk/client-s3 does not add aws.* attributes to the appropriate span
|
This is a bug but I have confirmed it is not a bug in instrumentation, just how we're mocking the aws server in versioned tests |
bizob2828
changed the title
github-project-automation
bot
moved this from In progress: Issues being worked on
to Done: Issues recently completed
in Node.js Engineering Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
It looks like in
@aws-sdk/[email protected]our versioned tests stop working. The reason is because the context manager returns the root span in addAwsAttribute middleware. It looks like the root cause is https://github.com/aws/aws-sdk-js-v3/pull/6232/files. The response is getting wrapped in a stream and we rely on the IncomingMessage to get the external span.Expected Behavior
s3 client adds the aws.* to the appropriate span.
Steps to Reproduce
npm run versioned:internal:major aws-sdk-v3The text was updated successfully, but these errors were encountered: