Fix Date Control Regression #1210
Conversation
|
Deploy preview for netlify-cms-www ready! Built with commit a294937 |
|
Deploy preview for cms-demo ready! Built with commit a294937 |
| this.format = field.get('format') || (includeTime ? DEFAULT_DATETIME_FORMAT : DEFAULT_DATE_FORMAT); | ||
| } | ||
|
|
There was a problem hiding this comment.
@tech4him1 any reason in constructor rather than in componentWillMount
I would have to test, but I would think the format could change from one collection to the next right?
There was a problem hiding this comment.
The format can change between collections.
Can you explain when componentWillMount should be used versus constructor?
There was a problem hiding this comment.
I may have made a bad assumption here. I thought we were talking about state changes 😛
There was a problem hiding this comment.
My assumption was incorrect, sorry for not looking closer first.
| this.format = field.get('format') || (includeTime ? DEFAULT_DATETIME_FORMAT : DEFAULT_DATE_FORMAT); | ||
| } | ||
|
|
There was a problem hiding this comment.
My assumption was incorrect, sorry for not looking closer first.
Fix regression from b7fcb8b. Dates were disappearing completely until the field was clicked into.
- Summary
Fix regression from b7fcb8b. Dates were disappearing completely until the field was clicked into.
- Test plan
Manually tested using
datetimewidget.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)