Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginix Docker Image Issue #197

Open
Dark-Helmet1 opened this issue Nov 27, 2024 · 2 comments
Open

Nginix Docker Image Issue #197

Dark-Helmet1 opened this issue Nov 27, 2024 · 2 comments
Labels
bug Something isn't working status: needs triage This issue is awaiting triage by a maintainer

Comments

@Dark-Helmet1
Copy link

Diode version

v0.6.0

Deployment type

docker compose

Deployment type version

docker compose

Diode SDK type

diode-sdk-python

Diode SDK version

v0.4.0

Diode NetBox Plugin version

v0.6.0

NetBox version

v4.1.1

Steps to reproduce

When deploying the docker diode server the nginx container does not actually apply the configuration as expected.

Step 1: Get compose file
curl -o docker-compose.yml https://raw.githubusercontent.com/netboxlabs/diode/develop/diode-server/docker/docker-compose.yaml

Step 2: Edit .env file

Step 3: docker-compose up -d

The issue presents itself as a redirect to port 443 since it is using the default nginx.conf that is present within the nginx:latest container. That file is not set to import from /etc/nginx/conf.d so the file created via compose is never used. Manually editing the nginx.conf file and restarting nginx allows it to work.

Expected behavior

The expectation was for docker-compose to bring everything up and not require manual edits within the containers.

Observed behavior

The default.conf file is placed in the nginx container, but Nginx does not automatically load that configuration

@Dark-Helmet1 Dark-Helmet1 added bug Something isn't working status: needs triage This issue is awaiting triage by a maintainer labels Nov 27, 2024
@mfiedorowicz
Copy link
Member

Hi @Dark-Helmet1, thanks for reporting, could you provide output of the following command extracting contents of /etc/nginx/conf.d/default.conf to help us triage further?

docker exec diode-ingress-nginx-1 /bin/sh -c "cat /etc/nginx/conf.d/default.conf"

@Dark-Helmet1
Copy link
Author

Dark-Helmet1 commented Nov 29, 2024

Sure. The default.conf file is written out correctly as I can use it manually.

docker exec diode-ingress-nginx-1 /bin/sh -c "cat /etc/nginx/conf.d/default.conf"
upstream diode-ingester {
server diode-ingester:8081;
} upstream diode-reconciler {
server diode-reconciler:8081;
} server {
listen 80;
http2 on;
server_name localhost;
client_max_body_size 25m;
location /diode/diode.v1.IngesterService {
rewrite /diode/(.) /$1 break;
grpc_pass grpc://diode-ingester;
}
location /diode/diode.v1.ReconcilerService {
rewrite /diode/(.
) /$1 break;
grpc_pass grpc://diode-reconciler;
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: needs triage This issue is awaiting triage by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants