-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧑💻 Clean code for improving readability and stability #522
Comments
The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md |
Stale issue message |
Stale issue message |
To reduce notifications, issues are locked until they are 🏁 status: ready for dev and to be assigned. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md |
What would you like to share?
Work Expected From The Issue
Improve the readability and stability of code by making the following changes listed below:
For example:
In the code below, the
3.14
value is used directly. So we can move into a constant data type declaration (as shown in the code snippet below the previous one).Use
std::cell::OnceCell
for declaring constant data types by constructing the value once before use. Similarly,std::sync::OnceLock
for declaring mutable static data types by constructing the value once before use.Rename functions, structs, enums, etc. according to the Rust convention.
Replace
&Option<T>
toOption<&T>
to stabilize the function signatures to reduce introducing breaking changes to the Codebase.For more information on how making this change can stabilize function signature. See:
https://piped.video/watch?v=6c7pZYP_iIE
Reasoning Behind The Proposed Changes
The reasoning behind the following changes is to improve the readability and stability of code, which can drastically improve developer
experience
and avoid unintentional breaking changes.Do you want to work on this issue?
None
Additional information
No response
The text was updated successfully, but these errors were encountered: