Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave for the search engine #319

Closed
Tracked by #313
neon-mmd opened this issue Oct 13, 2023 · 3 comments · Fixed by #335
Closed
Tracked by #313

Brave for the search engine #319

neon-mmd opened this issue Oct 13, 2023 · 3 comments · Fixed by #335

Comments

@neon-mmd
Copy link
Owner

neon-mmd commented Oct 13, 2023

Provide the Brave search engine for the websurfx search engine. To start working on this issue, you will need to create a new file with the name of the desired engine in the folder src/engines/ which is located under the codebase (websurfx directory). Then in the file, just create a new struct with the name of the engine and then create two impl blocks for the struct. One for implementing the SearchEngine trait on it and the other for implementing the parsers to be used for aggregating results.

After that, just put the name of the desired engine in the match statement located here, make sure that the name of engine is in lowercase.

After that, just move to the config file which is located at websurfx/ directory under the code base and then just edit the config file by including the name of the search engine here.

Note
The engine name to be included in the config file is not case sensitive but we would still recommend naming it with the camelcase naming convention.

After doing all the fore-mentioned steps, then we would suggest doing a thorough test to make sure everything works as intended and then submitting a PR.

@github-actions
Copy link

The issue has been unlocked and is now ready for dev. If you would like to work on this issue, you can comment to have it assigned to you. You can learn more in our contributing guide https://github.com/neon-mmd/websurfx/blob/rolling/CONTRIBUTING.md

@neon-mmd neon-mmd changed the title Brave for the search engine Brave for the search engine Oct 13, 2023
@JanKaczmarkiewicz
Copy link
Contributor

I can work on that.

@neon-mmd
Copy link
Owner Author

neon-mmd commented Oct 13, 2023

I can work on that.

Yes, sure 🙂 , I will assign this issue to you right away 🚀 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment