Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot override Neo4J Log Folder setting #193

Closed
ghost opened this issue Sep 11, 2019 · 2 comments
Closed

Cannot override Neo4J Log Folder setting #193

ghost opened this issue Sep 11, 2019 · 2 comments
Assignees
@jennyowen @bfeshti

Comments

@ghost
Copy link

ghost commented Sep 11, 2019

It looks like we are no longer able to override the value of where neo4j stores it log files. Originally we had this mapped to a folder located on the host using the environment variable "NEO4J_dbms_directories_logs"

Image Tag: neo4j:3.5.8-enterprise
Docker Version: 19.03.2
Operating System: Windows 10

Steps to reproduce:

  1. Create a docker-compose.yml
  2. Setup an environment variable called NEO4J_dbms_directories_logs as shown in attached
  3. Run docker-compose and observe

Expected behavour:

Log files to be stored in given folder specified by environment variable.

Actual Behaviour:

Default of "/logs/" always used.

Docker-Compose.txt
@ghost ghost assigned bfeshti and jennyowen Sep 11, 2019
@jennyowen
Copy link
Member

OK it looks as though this broke between 3.5.2 and 3.5.3 which was 21st Jan to 11th Feb. This is around the time I merged #161 which was a load of changes to the /logs mounting. That's probably what broke it.
There's a 3.5.10 release coming tomorrow ish, so I'll try get a fix in before then.

@jennyowen jennyowen mentioned this issue Sep 12, 2019
Merged
jennyowen added a commit that referenced this issue Sep 12, 2019
@jennyowen
env NEO4J_dbms_directories_logs was being overwritten by folder writa…
8a4b3cc 
…bility checking logic

The /logs folder is created in the Dockerfile, so it always exists, so the line to set NEO4J_dbms_directories_logs=/logs would always overwrite the configuration in the environment.
I made the assignment so that it only sets it to /logs if the variable is unassigned or empty.

This should fix issue #193

looks like I messed up doing a rebase and lost an important line of code
@jennyowen
Copy link
Member

@johncrocker OK this should be fixed by #194. The fix will be available in 3.5.10 which is due to be released very soon.

thanks for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennyowen jennyowen

@bfeshti bfeshti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennyowen @bfeshti