Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instantiator] Deprecate inaccessible constructors #441

Closed
theofidry opened this issue Jul 25, 2016 · 1 comment
Closed

[Instantiator] Deprecate inaccessible constructors #441

theofidry opened this issue Jul 25, 2016 · 1 comment
Milestone

Comments

@theofidry
Copy link
Member

The current instantiator works even if the constructor is private or protected. I personally feel like this is hacky as you are not instantiating the objects as they should normally, i.e. potentially create an object in a weird state. Besides, it's by far the most complex case.

Doing it is a legit use case IMO, but I don't think this should be in the core and much less enabled by default. If the user wants to do it, he should explicitly do so.

@tshelburne any opinion on this?

@theofidry theofidry modified the milestones: 3.x, 2.x Jul 25, 2016
@tshelburne
Copy link
Collaborator

Makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants