Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Deprecate range #329

Closed
theofidry opened this issue May 2, 2016 · 1 comment
Closed

[v2] Deprecate range #329

theofidry opened this issue May 2, 2016 · 1 comment
Labels
Milestone

Comments

@theofidry
Copy link
Member

As of now, the current regex (#\{([0-9]+)\.\.(\.?)([0-9]+)\}#i) allows both user{1..10} and user{1...10}. This makes it error prone which can be nice.

However, I think this can confuse the user as well (does it work well? Is it by design I as can't see anything in the doc about that?) and also if we support that I see no reason to not support user{0......10} for example.

Instead what about removing this behaviour in v3 and deprecating it in v2?

@tshelburne
Copy link
Collaborator

This makes sense to me.

@theofidry theofidry changed the title [v2][v3] Deprecate range [v2] Deprecate range May 3, 2016
@theofidry theofidry added this to the 2.x milestone May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants