Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved crop-mask integration #83

Open
3 tasks
gabrieltseng opened this issue Apr 15, 2022 · 1 comment
Open
3 tasks

Improved crop-mask integration #83

gabrieltseng opened this issue Apr 15, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@gabrieltseng
Copy link
Collaborator

We want to improve the integration between cropharvest and crop-mask.

On the CropHarvest side this consists of:

  • Renaming the tif files to follow a <location>_<date> naming convention instead of coupling them to the labels.geojson
  • Rewriting the Engineer to handle variable length tifs, instead of expecting 12-month inputs
  • Storing tifs to a google cloud bucket

This has the advantage of not requiring tif files to be downloaded before updating the dataset, which should make it easier to contribute new datasets.

cc @ivanzvonkov

@gabrieltseng gabrieltseng added the enhancement New feature or request label Apr 15, 2022
@gabrieltseng gabrieltseng self-assigned this Apr 15, 2022
@ivanzvonkov
Copy link
Contributor

You probably already know this but the Engineer can handle variable timesteps, it does so here: https://github.com/nasaharvest/crop-mask/blob/951b14621838d70eb95f284bf92984aaf35d4cb1/src/ETL/dataset.py#L109

I supposed the real question may be: should we reexport all the unexported tifs in the 24 month timestep style starting from January to make it easy to run models from September to September for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants