Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text length calculation broken with certain tags #46

Open
Dodoveloper opened this issue Jul 26, 2024 · 2 comments
Open

Text length calculation broken with certain tags #46

Dodoveloper opened this issue Jul 26, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Dodoveloper
Copy link

The issue is caused by the wait_finished signal not being emitted with certain tags.
This seems to be because the last variable in bbcodeWait.gd is never equal to length - 1, thus line 27 is never reached.

Forcing the skip by pressing the skip button lets me advance. There might be a clue there.

I noticed this bug with a couple of dialogues in the bbcode example. Specifically, the ones that have the [lb] tag, so it definitely has something to do with that.

I'm not sure how to fix it myself, but I hope this info can help!

@nagidev
Copy link
Owner

nagidev commented Jul 27, 2024

Yep this is a known issue (first one mentioned in README.md). I think the fix for this issue is probably a rewrite of the bbcodewait.gd file. I plan to do this as soon as I get some free time. So stay tuned!

@mdiluz
Copy link

mdiluz commented Aug 7, 2024

Just found this when using the current demos - the ExampleBBCodes demo breaks and doesn't show the OK buttons to progress because bbcodeWait.gd gets stuck looping never reaching what it think is the final character (char 67). Did a bunch of debugging to see if I could fix it for you but eventually found your FIXME comment at

# FIXME : Length calculation is borked when the value has [, ] unrelated to any bbcodes.

Seems like _update_wait_tags is maybe the true fix? bbcodewait's _process_custom_fx is simply acting on what seems like the wrong last dict entry value that was fed to it.

@nagidev nagidev added the bug Something isn't working label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants