-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async decode
to bao
#754
Comments
We are going to do this first for ourselves, and then try to get it merged once it works. The thing that is most urgent to implement async is the SliceDecoder . So we are going to have some async way to do the job of a SliceDecoder in our code base, and then PR that to bao. |
We currently don't need the |
I think the recommended way to send around verified data is the following:
If you want to identify one of the three steps where 1. async is easiest to add and 2. the lack of async is most annoying, it is the decoder. See the comment in oconnor663/bao#44 (comment)
|
I have written a completely independent slice decoder here: https://github.com/rklaehn/bao-experiment/blob/slice-decoder-2/src/lib.rs Getting that or something with equivalent functionality based on the bao code itself added to bao will be a longer term thing. |
The absolute minimum async support we are going to need is implemented in oconnor663/bao#46 There are a number of additional async things (seek support, encode support) that are nice to have but not strictly necessary. Those are in https://github.com/n0-computer/bao/ but don't need to go in for sendme 1.0 |
Not sure how to proceed with this. We now got our own crate bao-tree that supports all the things. Also we got abao which has an async decoder. |
PR: oconnor663/bao#44
The text was updated successfully, but these errors were encountered: