Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Support keyboard entry on mobile #7869

Open
2 tasks done
aleksey-lav opened this issue Feb 9, 2023 · 4 comments · May be fixed by #15671
Open
2 tasks done

[pickers] Support keyboard entry on mobile #7869

aleksey-lav opened this issue Feb 9, 2023 · 4 comments · May be fixed by #15671
Assignees
Labels
component: pickers This is the name of the generic UI component, not the React module! new feature New feature or request v8.x

Comments

@aleksey-lav
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example: https://codesandbox.io/s/silly-mirzakhani-dhigkw?file=/demo.tsx:1142-1158&resolutionWidth=320&resolutionHeight=675

Nothing happens if we add the prop disableOpenPicker to the component

Current behavior 😯

MobileTimePicker is opening with standard Clock view for choosing the time even disableOpenPicker is present as true

Expected behavior 🤔

The expectation to have a possibility to set the time without Clock, by typing as in DesktopTimePicker

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@aleksey-lav aleksey-lav added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 9, 2023
@zannager zannager transferred this issue from mui/material-ui Feb 9, 2023
@zannager zannager added the component: pickers This is the name of the generic UI component, not the React module! label Feb 9, 2023
@LukasTy
Copy link
Member

LukasTy commented Feb 14, 2023

Thank you for opening this issue!
Please refer to the API documentation or JSDoc in IDE for a prop description.
The current v5 release, has the following description for this prop:

Do not render open picker button (renders only text field with validation).

If you need to disable the component altogether, please refer to the disabled or readOnly props.

As for your mentioned "Expected behavior": we've had discussions about it, but I can't find any issue mentioning it, so I'll rename this one to better reflect the intent unless @flaviendelangle knows the issue we are talking about.

@LukasTy LukasTy added new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 14, 2023
@LukasTy LukasTy changed the title Prop disableOpenPicker doesn't work on MobileTimePicker component [pickers] Support keyboard entry on mobile Feb 14, 2023
@LukasTy
Copy link
Member

LukasTy commented Dec 27, 2023

Also correctly handle the clearable behavior with the removal of readonly mobile Pickers.
#10842 (comment)

@LukasTy
Copy link
Member

LukasTy commented Aug 6, 2024

We agreed to unify the field/input behavior on Mobile Pickers allowing editing in them just like React Spectrum does.
This would be a behavioral breaking change, thus, we are keeping it for the next major.

Once that is done, having the disableOpenPicker prop no longer makes sense as similar modifications can be done through the field slot, thus, we should deprecate it.

@LukasTy LukasTy removed the waiting for 👍 Waiting for upvotes label Aug 6, 2024
@flaviendelangle
Copy link
Member

flaviendelangle commented Aug 6, 2024

as similar modifications can be done through the field slo

Or by just rendering the field component.
Something like:

<DateField InputProps={{ endAdorment: "I don't remember the name of the icon" }} />

@flaviendelangle flaviendelangle self-assigned this Nov 29, 2024
@flaviendelangle flaviendelangle added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! new feature New feature or request v8.x
Projects
None yet
4 participants