Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Reshape row selection state model #15481

Open
Tracked by #13188
cherniavskii opened this issue Nov 19, 2024 · 2 comments · May be fixed by #15651
Open
Tracked by #13188

[data grid] Reshape row selection state model #15481

cherniavskii opened this issue Nov 19, 2024 · 2 comments · May be fixed by #15651
Assignees
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x

Comments

@cherniavskii
Copy link
Member

cherniavskii commented Nov 19, 2024

See #13757 (comment)

TODO:

  • Use Set instead of array
  • Change the model signature to support either inclusion or exclusion model
    { included: new Set() }
    // or
    { excluded: new Set() }

Problems:

  • We still need to go through each row to call the isRowSelectable prop. There is no way to overcome this if user provides the isRowSelectable prop. But if the prop is not provided, we can skip the whole looping over rows since all of them are selectable.
@cherniavskii cherniavskii added breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x labels Nov 19, 2024
@cherniavskii
Copy link
Member Author

@romgrk Does this proposal make sense to you?

@romgrk
Copy link
Contributor

romgrk commented Nov 19, 2024

LGTM

@cherniavskii cherniavskii self-assigned this Nov 25, 2024
@cherniavskii cherniavskii linked a pull request Nov 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants