Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Simplify the ownerState on every slot to only pass a small object with valuable information #14475

Open
70 of 72 tasks
flaviendelangle opened this issue Sep 4, 2024 · 0 comments
Assignees
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! dx Related to developers' experience v8.x

Comments

@flaviendelangle
Copy link
Member

flaviendelangle commented Sep 4, 2024

Right now, the ownerState passed to styled components or slots is the props of the component calling it (plus 1-2 properties on some occasions).
This make these objects very complex to reason about because people don't know which component is calling a certain slot and which props it has.
Additionally some valuable information are not part of those prop (the slots called by the useXXXPicker hooks don't even have the opening status).

Slots

Style overrides

The list might not be complete

Search keywords:

@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! dx Related to developers' experience v8.x labels Sep 4, 2024
@flaviendelangle flaviendelangle self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! dx Related to developers' experience v8.x
Projects
None yet
Development

No branches or pull requests

1 participant