Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Remove the PickersMonth and PickersYear component and move their logic inside MonthCalendar and YearCalendar #14474

Closed
flaviendelangle opened this issue Sep 4, 2024 · 2 comments · Fixed by #15806
Closed

[pickers] Remove the PickersMonth and PickersYear component and move their logic inside MonthCalendar and YearCalendar #14474

flaviendelangle opened this issue Sep 4, 2024 · 2 comments · Fixed by #15806
Assignees
@flaviendelangle
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x

Comments

@flaviendelangle
Copy link
Member

flaviendelangle commented Sep 4, 2024 •
edited by github-actions bot
Loading

Follow up on #13321

In v7, we introduced new monthButton and yearButton slots.
Now the PickersMonth and PickersYear are just super small wrappers on top of those slots.

This is a breaking change because it changes the theme entry (should be codemodable).

Search keywords:
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x labels Sep 4, 2024
@flaviendelangle flaviendelangle mentioned this issue Sep 4, 2024
Open
12 tasks
@LukasTy
Copy link
Member

LukasTy commented Sep 17, 2024

Try reducing the DOM nesting by going with grid layout instead.

@flaviendelangle flaviendelangle self-assigned this Dec 9, 2024
@flaviendelangle flaviendelangle mentioned this issue Dec 9, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Milestone
No milestone
2 participants
@flaviendelangle @LukasTy