Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove indeterminateCheckboxAction prop #14300

Closed
Tracked by #13188 ...
MBilalShafi opened this issue Aug 23, 2024 · 6 comments · Fixed by #15522
Closed
Tracked by #13188 ...

[data grid] Remove indeterminateCheckboxAction prop #14300

MBilalShafi opened this issue Aug 23, 2024 · 6 comments · Fixed by #15522
Assignees
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x

Comments

@MBilalShafi
Copy link
Member

MBilalShafi commented Aug 23, 2024

Remove the prop indeterminateCheckboxAction and make select the default behavior.

Context: #14247 (comment)

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 23, 2024
@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 23, 2024
@MBilalShafi MBilalShafi changed the title [data grid] Update indeterminateChecboxAction default value [data grid] Update indeterminateCheckboxAction default value Aug 23, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 28, 2024

Do we want to deprecate the indeterminateCheckboxAction prop in v8 and agree on select as the expected behavior?

👍 I think that we should go straight to change the default value and remove the prop in v8. See https://youtu.be/tRsxLLghL1k?si=sRhbVRHVLRR83pMX&t=574. "if you are not adding back at least 10% of what you are removing, you know you are not removing enough".

@MBilalShafi MBilalShafi changed the title [data grid] Update indeterminateCheckboxAction default value [data grid] Remove indeterminateCheckboxAction prop Nov 20, 2024
@marvelsrp
Copy link

I want to draw attention to the erroneous aria-label. It depends on isChecked, but is correctly related by checked.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 20, 2024

@marvelsrp Can you open a new issue or a PR? It looks broken indeed, but it's different from this issue. Thanks.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@oliviertassinari
Copy link
Member

@marvelsrp This is now fixed under the MUI X v8 release line.

@MBilalShafi
Copy link
Member Author

@marvelsrp This is now fixed under the MUI X v8 release line.

Adding, I'll soon port the fix to v7 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants