Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] TanStack Query integration demos #14227

Open
oliviertassinari opened this issue Aug 15, 2024 · 3 comments
Open

[data grid] TanStack Query integration demos #14227

oliviertassinari opened this issue Aug 15, 2024 · 3 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation waiting for 👍 Waiting for upvotes

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 15, 2024

Summary

I'm creating this issue to get a sense of the developer traction for having TanStack Query demos for data fetching with the grid. Seeing this tweet https://x.com/ericclemmons/status/1823108565285941266 and this chart https://npm-stat.com/charts.html?package=react-dom,@tanstack/react-query could suggest that there is an audience.

Examples

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! status: waiting for maintainer These issues haven't been looked at yet by a maintainer waiting for 👍 Waiting for upvotes labels Aug 15, 2024
@michelengelen michelengelen removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Aug 16, 2024
@MBilalShafi
Copy link
Member

MBilalShafi commented Aug 16, 2024

We do have one in the tree-data custom caching section but one with lazy-loading/infinite loading should be interesting. 👍

CC @arminmeh

@oliviertassinari
Copy link
Member Author

Interesting, I was thinking of having a dedicated TanStack Query set of examples, kind of an Integration doc, and having the rest of the demos more barebone, showing the raw concepts.

Maybe the ideal would be to support in docs-infra different variants of the demos. Like people could select between "Raw" and "TanStack Query" for all of those demos.

@arminmeh
Copy link
Contributor

arminmeh commented Oct 8, 2024

I looked briefly into it and I it seems that is better to have a separate integration page, since there is a lot of overlap between
TanStack Query and our own data source (especially after lazy loading is merged).

For both you provide a way to fetch the data and your UI is updated automatically. The additional thing that out data source has is the knowledge how to track the changes of the filter/sort/pagination models and adjust request params accordingly.

My point is, by using TanStack Query there is not much data source adds to it, so it does not feel that this is a data source specific example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation waiting for 👍 Waiting for upvotes
Projects
Status: 🆕 Needs refinement
Development

No branches or pull requests

4 participants