Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Replace d3-color by CSS filter #13938

Closed
alexfauquette opened this issue Jul 22, 2024 · 1 comment · Fixed by #15084
Closed

[charts] Replace d3-color by CSS filter #13938

alexfauquette opened this issue Jul 22, 2024 · 1 comment · Fixed by #15084
Labels
breaking change component: charts This is the name of the generic UI component, not the React module! v8.x

Comments

@alexfauquette
Copy link
Member

alexfauquette commented Jul 22, 2024

Charts rely on the d3-color to derive brighter colors from the initial series's color provided by the user.

Customizing it requires propagating more parameters such as proposed in #13907.

The proposed solution is to use CSS attribute filter to let user override the default color modification only by using CSS classes override

Relevant values:

  • filter: brightness(xx%)
  • filter: saturate(xx%)

Search keywords:

@alexfauquette alexfauquette added component: charts This is the name of the generic UI component, not the React module! v8.x labels Jul 22, 2024
@alexfauquette alexfauquette changed the title [charts] Replace d3-color by CSS filter [charts] Replace d3-color by CSS filter Jul 22, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: charts This is the name of the generic UI component, not the React module! v8.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant