Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Improve PickersDay component gridcell role management #11904

Open
shajjhusein opened this issue Feb 1, 2024 · 1 comment
Open

[pickers] Improve PickersDay component gridcell role management #11904

shajjhusein opened this issue Feb 1, 2024 · 1 comment
Labels
accessibility a11y breaking change bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! support: question Community support but can be turned into an improvement v8.x

Comments

@shajjhusein
Copy link

shajjhusein commented Feb 1, 2024

Steps to reproduce

Steps to Reproduce:

  • Implement PickersDay within a custom calendar component.
  • Conduct accessibility audit or testing with screen readers.
  • Observe the reported issue regarding the incorrect or misapplied use of the gridcell role.

Current behavior

image

Expected behavior

The expected is to have a solution to avoid the mentioned issue while wrapping the DayPicker in the renderDay function

Context

No response

Your environment

`npx @mui/envinfo`

System:
OS: Linux 5.15 Ubuntu 20.04.6 LTS (Focal Fossa)
Binaries:
Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
pnpm: Not Found
Browsers:
Chrome: 120.0.6099.109
npmPackages:
@emotion/react: ^11.11.1 => 11.11.3
@emotion/styled: ^11.11.0 => 11.11.0
@mui/base: 5.0.0-beta.33
@mui/core-downloads-tracker: 5.15.6
@mui/material: ^5.15.0 => 5.15.6
@mui/private-theming: 5.15.6
@mui/styled-engine: 5.15.6
@mui/system: ^5.14.18 => 5.15.6
@mui/types: 7.2.13
@mui/utils: 5.15.6
@mui/x-data-grid: ^6.18.2 => 6.19.2
@mui/x-date-pickers: ^5.0.20 => 5.0.20
@types/react: ^18.2.45 => 18.2.48
react: ^18.2.0 => 18.2.0
react-dom: ^18.2.0 => 18.2.0
typescript: ^4.4.4 => 4.9.5

Search keywords: Accessibility Issue with @mui/x-date-pickers PickersDay and ARIA roles

@shajjhusein shajjhusein added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 1, 2024
@michelengelen michelengelen added support: question Community support but can be turned into an improvement accessibility a11y status: waiting for author Issue with insufficient information component: pickers This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 2, 2024
@michelengelen michelengelen changed the title @mui/x-date-pickers PickersDay Accessibility [pickers] PickersDay Accessibility Feb 2, 2024
@LukasTy
Copy link
Member

LukasTy commented Feb 7, 2024

@shajjhusein Thank you for reporting this problem. 🙏
I can confirm that based on the guidelines([1], [2]), the button element should not have a gridcell role.
We'll look into fixing this problem. 😉

@LukasTy LukasTy added bug 🐛 Something doesn't work and removed status: waiting for author Issue with insufficient information labels Feb 7, 2024
@LukasTy LukasTy changed the title [pickers] PickersDay Accessibility [pickers] PickersDay button with gridcell role Feb 7, 2024
@flaviendelangle flaviendelangle changed the title [pickers] PickersDay button with gridcell role [pickers] Change the role of the PickersDay button to be gridcell Sep 30, 2024
@LukasTy LukasTy changed the title [pickers] Change the role of the PickersDay button to be gridcell [pickers] Improve PickersDay component gridcell role management Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y breaking change bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! support: question Community support but can be turned into an improvement v8.x
Projects
None yet
Development

No branches or pull requests

3 participants