-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DateTimeRangePicker] Change OK button behavior #11829
Comments
@joserodolfofreitas we would like to pick this up |
Thank you for offering to take on this issue! We recommend getting started on issues labeled with "good first issue". Currently, there are no Date pickers issues with that label, but we're looking into that. |
We decided to go with the suggested approach. |
I had some insights and challenges while working on this issue. Perhaps it can be useful for future discussions about not only the action bar, but for all the slots we use in the Pickers: Creating a new
Keep only the
Last consideration is that the ActionBar is defined on the community package, so adding range information requires passing additional props to common hooks, for example to change the range position, which doesn't improve the code readability. It also touches the Pickers Layout, which is also common among the packages, so the complexity scales in different layers. |
Similar to what was commented here, we will postpone this task for v8. We could use this time to define which solution suits better our needs. Some insights from @joserodolfofreitas and @flaviendelangle would be very appreciated 🙂 |
Steps to reproduce
Link to live example: (required)
Steps:
Screen.Recording.2024-01-27.at.08.01.30.mov
Current behavior
If users click the OK button on the
start
input, it closes the view.Expected behavior
If users click the OK button on the
start
input, it should move to theend
input.Context
No response
Your environment
npx @mui/envinfo
Search keywords: datetimerangepicker okbutton
The text was updated successfully, but these errors were encountered: