-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Field text selection on mouseDown #10048
Comments
@oliviertassinari I agree that the behavior seems a bit strange 🤔 The first section is selected on mouse down/ on focus, but then you have to wait for mouse up for the next section that you clicked on to be highlighted🤔 I am not sure about the drawback of not being able to select multiple sections, however... I'll add this to the list of items that need grooming to discuss it in more detail with the team 👍 |
@oliviertassinari we would like to pick this up |
@gitstart I've assigned this issue to you, feel free to explore a solution. |
Any update on this? |
@gitstart did you have a chance to investigate this issue? 🤔 |
Such a behavior is already present on the accessible DOM structure. Given that it will become the default on v8, there is no clear rushing factor to implement it on the input behavior. |
@LukasTy Could we check the customization story before we change the default? Having a demo would be great https://mui.com/x/react-date-pickers/custom-field/#using-material-textfield feels like how most people should customize the date picker. I mean, I would expect most people to come here and not use the Material UI text field raw but with a custom one they have created wrapping the Material UI one. When we add Screen.Recording.2024-10-16.at.20.39.12.movAnd no, https://mui.com/x/react-date-pickers/custom-field/#using-material-pickerstextfield, I don't think that this is usable. To me |
Summary 💡
It would be nice not to see the caret on the date field when selection a segment of the date. I think it would feel better, based on playing with the Chrome native date picker and React Aria.
I don't know how much effort this is, so to consider the ROI, it's not a huge UX improvement.
Examples 🌈
On https://react-spectrum.adobe.com/react-spectrum/DatePicker.html#datepicker, you don't see the mouse down caret, it selects the relevant section on
mouseDown
:Screen.Recording.2023-08-16.at.13.02.11.mov
On https://mui.com/x/react-date-pickers/date-picker/, you see it, it feels a bit strange to wait for the
mouseUp
event:Screen.Recording.2023-08-16.at.13.02.35.mov
There is a limit though, you can also see text selection 🙈
Screen.Recording.2023-08-16.at.13.07.43.mov
Motivation 🔦
No response
Order ID 💳 (optional)
No response
The text was updated successfully, but these errors were encountered: