Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Migrate Next.js config.next.js to config.next.mjs #42568

Open
oliviertassinari opened this issue Jun 7, 2024 · 4 comments · May be fixed by #44040
Open

[examples] Migrate Next.js config.next.js to config.next.mjs #42568

oliviertassinari opened this issue Jun 7, 2024 · 4 comments · May be fixed by #44040
Labels
enhancement This is not a bug, nor a new feature examples Relating to /examples nextjs ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 7, 2024 •
edited
Loading

Steps to reproduce

See https://github.com/mui/material-ui/blob/master/examples/material-ui-nextjs-pages-router-ts/next.config.js

Current behavior

next.config.js file

Expected behavior

next.config.mjs

Context

No response

Your environment

npx @mui/envinfo 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: -
@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer examples Relating to /examples nextjs enhancement This is not a bug, nor a new feature labels Jun 7, 2024
@oliviertassinari
Copy link
Member Author

Well, maybe we don't need to do this actually. It's for the Page Router, I did the bulk of the replacements in #40661.

@siriwatknp siriwatknp added good first issue Great for first contributions. Enable to learn the contribution process. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 26, 2024
@wojtek35
Copy link
Contributor

Does this still need to be done? I could do it

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 25, 2024 •
edited
Loading

This issue is still relevant, a bunch of those are outdated, proof: https://github.com/search?q=org%3Amui+next.config.js&type=code.

@Tomar606
Copy link

Hi, I've submitted a pull request to address this issue.
It converts the next.config.js to next.config.mjs.
p.s.- It's my first try contributing in an open source project.

@oliviertassinari oliviertassinari mentioned this issue Sep 29, 2024
Closed
@oliviertassinari oliviertassinari added ready to take Help wanted. Guidance available. There is a high chance the change will be accepted and removed good first issue Great for first contributions. Enable to learn the contribution process. labels Sep 29, 2024
@albarv340 albarv340 linked a pull request Oct 8, 2024 that will close this issue
Open
1 task
@samuelsycamore samuelsycamore removed their assignment Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature examples Relating to /examples nextjs ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[examples] Migrate Next.js config.next.js to config.next.mjs albarv340/material-ui
5 participants
@oliviertassinari @siriwatknp @wojtek35 @samuelsycamore @Tomar606