Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LoadingButton] Displaying incorrect warning #31235

Open
songhobby opened this issue Feb 28, 2022 · 17 comments · Fixed by #42987 · May be fixed by #44637
Open

[LoadingButton] Displaying incorrect warning #31235

songhobby opened this issue Feb 28, 2022 · 17 comments · Fixed by #42987 · May be fixed by #44637
Labels
bug 🐛 Something doesn't work component: LoadingButton The React component. package: lab Specific to @mui/lab

Comments

@songhobby
Copy link

songhobby commented Feb 28, 2022

Current behavior 😯

<LoadingButton loadingPosition="start" .. .>...

This would prompt a warning

Warning: Failed prop type: MUI: The loadingPosition="start" should be used in combination with startIcon.'

However, the default loadingIndicator is used and a startIcon is not necessary here

Expected behavior 🤔

No warning

Steps to reproduce 🕹

No response

Context 🔦

No response

Your environment 🌎

No response

@songhobby songhobby added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 28, 2022
@danilo-leal danilo-leal changed the title Loading button incorrect warning [LoadingButton] Displaying incorrect warning Feb 28, 2022
@danilo-leal danilo-leal added component: LoadingButton The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 28, 2022
@andrebnassis
Copy link

Here there is a repository with a LoadingButton sample that you can reproduce the warning message:
https://github.com/andrebnassis/my-lab/tree/issue/mui/31365

@shkhalid
Copy link

+1

1 similar comment
@nishina-y
Copy link

+1

@buzzb0x
Copy link

buzzb0x commented Jan 17, 2023

Hi there, any updates on this? Has this been fixed already? I'm on @mui/[email protected] and the warning is still present

@CorentinR3
Copy link

+1

@baki-kucukcakiroglu
Copy link

+1. I can confirm this issue still exists at "@mui/lab": "^5.0.0-alpha.142".

@ZeeshanTamboli
Copy link
Member

It works well in Joy UI without any warning. See - https://mui.com/joy-ui/react-button/#loading-position.

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work package: lab Specific to @mui/lab labels Nov 11, 2023
@mmoreno2-rbi
Copy link

+1

2 similar comments
@andrew-amp
Copy link

+1

@woigl
Copy link

woigl commented Feb 12, 2024

+1

@simarmannsingh
Copy link

+1. Still getting a warning for @mui/lab": "^5.0.0-alpha.170".

@dil-anunez
Copy link

I can confirm this in "@mui/lab": "5.0.0-alpha.170" and "@mui/material": "^5.14.17",

@CorentinR3
Copy link

+1

@jfaMan
Copy link

jfaMan commented Aug 13, 2024

+1 with "@mui/lab": "^5.0.0-alpha.69"

@triglian
Copy link

Hello, also experiencing this, any plans to fix it?

@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented Nov 1, 2024

We're moving the loading feature to the Material UI Button in #42987. The warning won’t be added there.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@songhobby How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@ZeeshanTamboli ZeeshanTamboli linked a pull request Dec 6, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: LoadingButton The React component. package: lab Specific to @mui/lab
Projects
None yet