Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Role of Skeleton #28057

Closed
shayantabrizi opened this issue Aug 30, 2021 · 4 comments
Closed

Role of Skeleton #28057

shayantabrizi opened this issue Aug 30, 2021 · 4 comments
Labels
component: skeleton This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists

Comments

@shayantabrizi
Copy link

Shouldn't Skeleton component have a role of progressbar?

@shayantabrizi shayantabrizi added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 30, 2021
@oliviertassinari oliviertassinari added the component: skeleton This is the name of the generic UI component, not the React module! label Aug 30, 2021
@oliviertassinari
Copy link
Member

As far as I know, no. Closing as it's an extension of #26930

@oliviertassinari oliviertassinari added duplicate This issue or pull request already exists and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 30, 2021
@shayantabrizi
Copy link
Author

Could you please explain why? Doesn't Skeleton show waiting for the result, similar to progressbar? If not, what is the correct role?

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 1, 2021

Please have a read at the duplicate issue I have linked. It links other discussions that provides context. From what I remember, the fundamental problem is that the nominal use case is to have multiple Skeleton rendered, while there is only one loading area. So aria attributes can't be hosted by the Skeleton, it's the responsibility of the developers to add them on the container.

@shayantabrizi
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: skeleton This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants