Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process hangs on node <= 14.1.0 and performance issue #160

Closed
davidfirst opened this issue Jul 20, 2020 · 1 comment
Closed

Process hangs on node <= 14.1.0 and performance issue #160

davidfirst opened this issue Jul 20, 2020 · 1 comment

Comments

@davidfirst
Copy link

I created a reproducible repo https://github.com/davidfirst/stream-issue-node-14-1-0 with instructions on how to reproduce.

In short, I run exec() and write data (string) to the ssh server through the stream.stdin. When the string is small (~1MB) it works with no issue. When the string is 10MB it works on node <=14.0.0 but it hangs on node >= 14.1.0.

Another issue I found, not related to any node version is the performance. The longer the string the lower the transfer rate. I have a feeling that it is related to the back-pressure, but I tried with piping as well, which suppose to handle the backpressure.

More details in the README of the repo above.

I didn't create two issues because there is a good chance that fixing the performance issue will fix the first issue as well.

(to have some more context for this issue, see teambit/bit#2844.

@davidfirst
Copy link
Author

Oops, I realized I opened the issue in the wrong place. I'm closing this.
I opened it in the ssh2 repo. mscdex/ssh2#908.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant