Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FEATURE ] Add exit animations #213

Open
billnye2 opened this issue Aug 19, 2024 · 1 comment
Open

[ FEATURE ] Add exit animations #213

billnye2 opened this issue Aug 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@billnye2
Copy link

Is your feature request related to a problem? Please describe.
Hey really cool lib, I'm gonna try using it. Noticed that the enter animations are nice and mimic og shadcn nicely. But also see that exit animations aren't implemented yet, for instance the dropdown menu immediately disappears on exit rather than animating with a fade out. This was tested on the web demo, not sure what mobile side looks like yet. I believe shadcn added exit animations to his lib around a year ago. Wondering if this is on the roadmap?

Great library,
Thanks!

@billnye2 billnye2 added the enhancement New feature or request label Aug 19, 2024
@RWOverdijk
Copy link
Contributor

I'd like to add to this that I see the same with popover. It appears to "flicker". It has an animation (exit fadeOut) but somewhere in the chain it goes wrong.

I think an attempt has been made but perhaps it's just not done yet. I might take a crack at this once I start looking at rn-primitives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants