Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the key of [email protected] for the unit test (#882) #906

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

ikedam
Copy link
Contributor

@ikedam ikedam commented Jul 23, 2021

  • golang.org/x/crypto/openpgp requires keys contain identity information.
  • A email address can have only a single key with identity information on keys.openpgp.org.

[email protected], used in keys for unit tests is currently associated to 388B914AFF8BC589962CFA2D996E14AC4DB5EC62: https://keys.openpgp.org/search?q=secops%40mozilla.com
I'm not sure it's permanent one.

The key for [email protected] is used for release of FireFox, and I believe we can rely on that's permanent.
https://keys.openpgp.org/search?q=release%40mozilla.com

* `golang.org/x/crypto/openpgp` requires keys contain identity information.
* A email address can have only a single key with identity information on keys.openpgp.org.
@felixfontein
Copy link
Contributor

LGTM

@autrilla @ajvb can you please take a look? This would make CI work again.

@autrilla autrilla merged commit 6130ffe into getsops:develop Jul 24, 2021
@autrilla
Copy link
Contributor

Thanks!

@cameronkerrnz
Copy link

So now we only need this to be merged into the master branch for various PRs to be unblocked?

@ikedam
Copy link
Contributor Author

ikedam commented Jul 25, 2021

Pull requests are usually targeted to the develop branch and no need to be merged to the master branch soon.
CIs aren't rerun automatically, and you have to click "Re-run" in "Checks" tab (supposed to be clickable only when you are a maintainer of the repository) or close / reopen the pull request.

@felixfontein
Copy link
Contributor

I think the current develop is only merged to master on release. So basically master is the latest released version.

simcax pushed a commit to simcax/sops that referenced this pull request Sep 23, 2023
…etsops#906)

* `golang.org/x/crypto/openpgp` requires keys contain identity information.
* A email address can have only a single key with identity information on keys.openpgp.org.

Signed-off-by: Carsten Skov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants