Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for thread-safe slot mode #1750

Open
gbrail opened this issue Dec 7, 2024 · 1 comment
Open

Add tests for thread-safe slot mode #1750

gbrail opened this issue Dec 7, 2024 · 1 comment

Comments

@gbrail
Copy link
Collaborator

gbrail commented Dec 7, 2024

Since we made "thread safe objects" an option a while back, we have very little testing of this feature, and @nabacg recently found a bunch of problems with the implementation. We should (in increasing order of difficulty):

  1. Set up Test262SuiteTests to run the tests with this flag set
  2. If we (and @rbri ) can get feature flag support set up, we can make this a feature flag too
  3. Once we do that, we can run all the tests with this flag set

Now, since we already have a bunch of tests that take quite a while to run, I think that whatever we do should be an optional flag that we turn on only in CI.

@andreabergia
Copy link
Contributor

I would at least recommend to run test262 with the thread-safety feature turned on, especially after #1754

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants