Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Add distinct notifications for new versus existing passes #815

Open
bsurd opened this issue Nov 27, 2019 · 1 comment
Open

Add distinct notifications for new versus existing passes #815

bsurd opened this issue Nov 27, 2019 · 1 comment
Labels
enhancement New feature or request [QA]:Enhancement Label for QA to mark enhancements logged

Comments

@bsurd
Copy link

bsurd commented Nov 27, 2019

Notes:

  • The message could be enhanced in this situation to be less confusing for a user as he already had the said passes and only use the x new version for when the passes are reset/he receives new passes each month.

Affected Platforms:

  • Windows 10 (64-bit)
  • Mac 10.14.2
  • Linux Ubuntu 19.04

Affected versions:

  • signed v17 build

Steps to reproduce

  1. Log into SP with a user who has a limited version of the proxy.
  2. Use one or multiple passes.
  3. On a different machine log in with the same account.

Expected result

  • The passes notification reads "You have x Firefox Private Network passes!" or "You have x Firefox Private Network passes remaining!"

Actual result:

  • The passes notification reads "You have x new Firefox Private Network passes!".

image

@bsurd bsurd added enhancement New feature or request [QA]:Enhancement Label for QA to mark enhancements logged labels Nov 27, 2019
@bakulf
Copy link
Collaborator

bakulf commented Nov 27, 2019

@betsymi what do you think about this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request [QA]:Enhancement Label for QA to mark enhancements logged
Projects
None yet
Development

No branches or pull requests

2 participants