Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Addition] Compatibility for Python 3.12 #1021

Closed
crayolakat opened this issue Mar 19, 2024 · 6 comments
Closed

[Feature/Addition] Compatibility for Python 3.12 #1021

crayolakat opened this issue Mar 19, 2024 · 6 comments
Labels
blocked Status - work is blocked by another issue or by outside factors enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage futureproofing Impact - something is working right now, but will break soon (e.g. due to a tool API changing) low priority Priority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons

Comments

@crayolakat
Copy link
Collaborator

crayolakat commented Mar 19, 2024

Detailed Description

Provide compatibility for Python 3.12, the latest minor release of Python. Currently, Parsons is compatibility up to and including Python 3.10. #1012 brings the compatibility up to and including 3.11, but has not been merged into the main branch or released yet.

Possible Implementation

Update to Python 3.12 and test to see if anything breaks or is now incompatibile.

Priority

Low priority

@crayolakat crayolakat added enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage futureproofing Impact - something is working right now, but will break soon (e.g. due to a tool API changing) labels Mar 19, 2024
@shaunagm
Copy link
Collaborator

Hi @crayolakat! In testing we discovered that PETL does not yet support 3.12, this is a crucial dependency so until PETL updates, we're stuck. Once they've updated, we can circle back and support 3.12

@shaunagm shaunagm added blocked Status - work is blocked by another issue or by outside factors low priority Priority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons labels Apr 16, 2024
@crayolakat
Copy link
Collaborator Author

Ok, thanks for looking into this!

@jdw25
Copy link
Collaborator

jdw25 commented May 13, 2024

@shaunagm -- does this answer and this addition of 3.12 into PETL CI testing mean we we can now consider support for 3.12 not blocked by PETL?

I think supporting Python 3.12 would be beneficial -- 3.12 is the default install for Ubuntu 24 LTS (which is the latest-greatest LTS Ubuntu release)

@shaunagm
Copy link
Collaborator

Yes, you're right @jdw25 that PETL is not a blocker. So next step is for someone to open a PR adding 3.12 to our test suite in github actions, and see if everything passes (plus add it to our docs & readme & setup.py as well). If it does, adding 3.12 support is as simple as merging, otherwise we'll have additional work to do.

@jdw25
Copy link
Collaborator

jdw25 commented Jun 27, 2024

This should now be complete with #1087

@shaunagm
Copy link
Collaborator

Thank you @jdw25!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Status - work is blocked by another issue or by outside factors enhancement Impact - something should be added to or changed about Parsons that isn't causing a current breakage futureproofing Impact - something is working right now, but will break soon (e.g. due to a tool API changing) low priority Priority - this is a nice-to-have, is non-urgent, and/or has a minor overall imapact on Parsons
Projects
None yet
Development

No branches or pull requests

3 participants