Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a more correct aabb bound derived from scalar max gaussian scale #132

Open
github-actions bot opened this issue Dec 18, 2024 · 0 comments
Open
Assignees
Labels

Comments

@github-actions
Copy link

#[cfg(feature = "f16")]

// TODO: find a more correct aabb bound derived from scalar max gaussian scale

        &mut self.position_visibility[index].visibility
    }

    pub fn compute_aabb(&self) -> Option<Aabb> {
        if self.is_empty() {
            return None;
        }

        let mut min = Vec3::splat(f32::INFINITY);
        let mut max = Vec3::splat(f32::NEG_INFINITY);

        // TODO: find a more correct aabb bound derived from scalar max gaussian scale
        let max_scale = 0.1;

        for position in self.position_iter() {
            min = min.min(Vec3::from(*position) - Vec3::splat(max_scale));
            max = max.max(Vec3::from(*position) + Vec3::splat(max_scale));
        }

        Aabb::from_min_max(min, max).into()
    }


    // pub fn rotation(&self, index: usize) -> &[f32; 4] {
    //     #[cfg(feature = "f16")]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant