Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.8 failing with: "go": executable file not found in $PATH #135

Closed
hnrkndrssn opened this issue Jul 26, 2024 · 5 comments · Fixed by #136
Closed

v2.5.8 failing with: "go": executable file not found in $PATH #135

hnrkndrssn opened this issue Jul 26, 2024 · 5 comments · Fixed by #136

Comments

@hnrkndrssn
Copy link

v2.5.7 build successful https://github.com/OctopusDeployLabs/terraform-provider-octopusdeploy/actions/runs/10106749988/job/27949407229?pr=690

v2.5.8 build failed https://github.com/OctopusDeployLabs/terraform-provider-octopusdeploy/actions/runs/10106735748/job/27949369024

@mikeatlas
Copy link

This is problematic for me since my org has only approved the v2 tag which presumably is loading 2.5.8. As such I can't simply specify the minor version 2.5.7 without going through some internal hurdles. It'd be great to have this fixed quickly...

@morphy2k
Copy link
Owner

Caused by this mgechev/revive@4242f24#diff-d11e824011a3a8f692c13fb88e333ea5c84a40b02ed50566d4775e0238c25507R127

Revive now requires Go on the system. Wasn't documented anywhere.

I will fix it with a new release in the next few hours.

@mikeatlas
Copy link

confirmed - #136 is working (v2.5.9)

@morphy2k
Copy link
Owner

The dependency on Go has been removed again (mgechev/revive#1025). So we'll be able to undo the changes with the next Revive release. So again, standalone and small Docker image.

@morphy2k
Copy link
Owner

morphy2k commented Sep 26, 2024

With the just released 2.5.11, everything should be as it was before #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants